Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevOverlay] Add error message #74541

Merged
merged 1 commit into from
Jan 6, 2025
Merged

[DevOverlay] Add error message #74541

merged 1 commit into from
Jan 6, 2025
+90 −27

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Jan 6, 2025 •
edited
Loading

This PR separated the error message component.

Light

CleanShot 2025-01-06 at 18 20 31

Dark

CleanShot 2025-01-06 at 18 21 47

Closes NDX-608

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 6, 2025
@devjiwonchoi Graphite App
Copy link
Member Author

devjiwonchoi commented Jan 6, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ijjk
Copy link
Member

ijjk commented Jan 6, 2025 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-06-_devoverlay_add_error_message Change
buildDuration 24.1s 21.6s N/A
buildDurationCached 20.5s 18.2s N/A
nodeModulesSize 417 MB 417 MB ⚠️ +29.1 kB
nextStartRea..uration (ms) 567ms 578ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 01-06-_devoverlay_add_error_message Change
1187-HASH.js gzip 52.6 kB 52.6 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-06-_devoverlay_add_error_message Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js 01-06-_devoverlay_add_error_message Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js 01-06-_devoverlay_add_error_message Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-06-_devoverlay_add_error_message Change
index.html gzip 523 B 523 B ✓
link.html gzip 538 B 535 B N/A
withRouter.html gzip 519 B 519 B ✓
Overall change 1.04 kB 1.04 kB ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-06-_devoverlay_add_error_message Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 206 kB 206 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js 01-06-_devoverlay_add_error_message Change
middleware-b..fest.js gzip 671 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js 01-06-_devoverlay_add_error_message Change
274-experime...dev.js gzip 322 B 322 B ✓
274.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 363 kB 363 kB N/A
app-page-exp..prod.js gzip 129 kB 129 kB ✓
app-page-tur..prod.js gzip 142 kB 142 kB ✓
app-page-tur..prod.js gzip 138 kB 138 kB ✓
app-page.run...dev.js gzip 352 kB 352 kB N/A
app-page.run..prod.js gzip 125 kB 125 kB ✓
app-route-ex...dev.js gzip 37.5 kB 37.5 kB ✓
app-route-ex..prod.js gzip 25.5 kB 25.5 kB ✓
app-route-tu..prod.js gzip 25.5 kB 25.5 kB ✓
app-route-tu..prod.js gzip 25.4 kB 25.4 kB ✓
app-route.ru...dev.js gzip 39.2 kB 39.2 kB ✓
app-route.ru..prod.js gzip 25.4 kB 25.4 kB ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.7 kB 21.7 kB ✓
pages.runtim...dev.js gzip 27.5 kB 27.5 kB ✓
pages.runtim..prod.js gzip 21.7 kB 21.7 kB ✓
server.runti..prod.js gzip 916 kB 916 kB ✓
Overall change 1.73 MB 1.73 MB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-06-_devoverlay_add_error_message Change
0.pack gzip 2.09 MB 2.09 MB ⚠️ +271 B
index.pack gzip 74.7 kB 73.9 kB N/A
Overall change 2.09 MB 2.09 MB ⚠️ +271 B
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js 
failed to diff
Diff for app-page.runtime.dev.js 
failed to diff
Commit: 11fc4fe

@ijjk
Copy link
Member

ijjk commented Jan 6, 2025 •
edited
Loading

Tests Passed

@devjiwonchoi devjiwonchoi mentioned this pull request Jan 6, 2025
Merged
@devjiwonchoi devjiwonchoi marked this pull request as ready for review January 6, 2025 10:10
@devjiwonchoi devjiwonchoi force-pushed the 01-06-_devoverlay_add_error_message branch from 222e098 to 31ecf15 Compare January 6, 2025 12:31
@devjiwonchoi devjiwonchoi force-pushed the 01-06-_devoverlay_add_error_message branch from 31ecf15 to 11fc4fe Compare January 6, 2025 16:10
This was referenced Jan 6, 2025
Merged
Merged
@devjiwonchoi devjiwonchoi merged commit 18ee367 into canary Jan 6, 2025
132 checks passed
@devjiwonchoi Graphite App
Copy link
Member Author

Merge activity

  • Jan 6, 1:51 PM EST: A user merged this pull request with Graphite.

@devjiwonchoi devjiwonchoi deleted the 01-06-_devoverlay_add_error_message branch January 6, 2025 18:51
This was referenced Jan 7, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

@huozhi huozhi huozhi approved these changes

@gaojude gaojude Awaiting requested review from gaojude

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devjiwonchoi @ijjk @huozhi @eps1lon